Skip to content

Fix #2478: Delete docs folder#2479

Merged
sebjulliand merged 2 commits intocodefori:masterfrom
MohitKambli:vscode-ibmi-branch
Jan 27, 2025
Merged

Fix #2478: Delete docs folder#2479
sebjulliand merged 2 commits intocodefori:masterfrom
MohitKambli:vscode-ibmi-branch

Conversation

@MohitKambli
Copy link
Contributor

Changes

Hello,
As requested in issue #2478, I have simply deleted the docs folder from the project's root directory
If at all you find any mistakes from my end or I implemented anything incorrectly, then do let me know
Sincere apologies for my mistakes if you find any

Thanks and Regards,
Mohit Kambli

How to test this PR

Examples:

  1. Run the test cases
  2. Expand view A and right click on the node
  3. Run 'Execute Thing' from the command palette

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@sebjulliand sebjulliand self-requested a review January 24, 2025 08:32
@sebjulliand sebjulliand added the documentation Improvements or additions to documentation label Jan 24, 2025
@sebjulliand
Copy link
Member

Thank you @MohitKambli !
Two things I'd require you do:

  • Update the URL on line 14 in CONTRIBUTING.md to make it point to the actual documentation repository instead of the file being deleted: https://github.com/codefori/docs
  • Add yourself to the contributors in CONTRIBUTING.md as well 😉

@MohitKambli
Copy link
Contributor Author

Hello @sebjulliand,
As you have requested, I have made the necessary changes in the CONTRIBUTING.md file
Kindly have a look at them and let me know if there are any changes required from my end

Thanks and Regards,
Mohit Kambli

@sebjulliand
Copy link
Member

Perfect; thank you for your contribution @MohitKambli !

@sebjulliand sebjulliand merged commit 1ae207f into codefori:master Jan 27, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants